Document REE row format and add some more tests #7680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
not that I have any power here, but lgtm |
Contributor
Author
Well, I view it as part of the original PR that you wrote so given it does not add any new features I don't think it is controversial I'll plan to merge it in once the tests pass to avoid conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until #7649 is mergedWhich issue does this PR close?
Rationale for this change
I noticed some extra testing and docs I would like to see so I made a PR to add them
What changes are included in this PR?
Are there any user-facing changes?
No code changes, only some docs (and more tests)