Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jun 23, 2025

Note this targets a release branch, not main

I have a different proposed fix for main:

I will also make a fix for parquet-variant test failures

Which issue does this PR close?

Rationale for this change

cargo test --all requires python and pyarrow installed, where it did not in previous versions of arrow due to breaking out arrow-pyarrow into its own crate in

Also the new parquet-variant crate tests fail as part of the verification script too -- see ttps://github.com//issues/7746

In order to get a script that can automatically verify a release candidate, let's ignore this new module for now.

More details

Note that the arrow-pyarrow tests do run as part of CI and succeed on this branch

What changes are included in this PR?

  1. Exclude running the arrow-pyarrow and parquet-variant tests as part of verify-release-acndidate

Testing

I verified locally that ./dev/release/verify-release-candidate.sh 55.2.0 1 passes with this script

Are there any user-facing changes?

No this is a development process only change

@alamb alamb added the development-process Related to development process of arrow-rs label Jun 23, 2025
@alamb alamb marked this pull request as ready for review June 23, 2025 13:14
@alamb alamb changed the title [55_maintenance] Fix verify-release-candidate.sh by skipping arrow-pyarrow [55_maintenance] Fix verify-release-candidate.sh by skipping arrow-pyarrow and parquet-variant Jun 23, 2025
@alamb
Copy link
Contributor Author

alamb commented Jun 23, 2025

Thanks @brunal !

@alamb alamb merged commit 25114c5 into apache:55_maintenance Jun 23, 2025
9 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jun 23, 2025

I am merging this one and will make a real PR for #7746 later

@alamb alamb deleted the alamb/fix_verify_release branch June 23, 2025 13:44
berkaysynnada pushed a commit to synnada-ai/arrow-rs that referenced this pull request Jul 17, 2025
…yarrow` and `parquet-variant` (apache#7745)

Note this targets a release branch, not main

I have a different proposed fix for `main`:
- apache#7742

I will also make a fix for parquet-variant test failures

# Which issue does this PR close?

- Related to apache#7394
- Related to apache#7736
- Related to apache#7746

# Rationale for this change

`cargo test --all` requires python and pyarrow installed, where it did
not in previous versions of arrow due to breaking out `arrow-pyarrow`
into its own crate in
- apache#7694

Also the new `parquet-variant` crate tests fail as part of the
verification script too -- see
ttps://github.com/apache/issues/7746


In order to get a script that can automatically verify a release
candidate, let's ignore this new module for now.

More details 
- apache#7736 
- apache#7742

Note that the arrow-pyarrow tests do run as part of CI and succeed on
this branch


# What changes are included in this PR?

1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests as
part of `verify-release-acndidate`


# Testing
I verified locally that `./dev/release/verify-release-candidate.sh
55.2.0 1` passes with this script

# Are there any user-facing changes?
No this is a development process only change
berkaysynnada pushed a commit to synnada-ai/arrow-rs that referenced this pull request Aug 26, 2025
…yarrow` and `parquet-variant` (apache#7745)

Note this targets a release branch, not main

I have a different proposed fix for `main`:
- apache#7742

I will also make a fix for parquet-variant test failures

# Which issue does this PR close?

- Related to apache#7394
- Related to apache#7736
- Related to apache#7746

# Rationale for this change

`cargo test --all` requires python and pyarrow installed, where it did
not in previous versions of arrow due to breaking out `arrow-pyarrow`
into its own crate in
- apache#7694

Also the new `parquet-variant` crate tests fail as part of the
verification script too -- see
ttps://github.com/apache/issues/7746


In order to get a script that can automatically verify a release
candidate, let's ignore this new module for now.

More details 
- apache#7736 
- apache#7742

Note that the arrow-pyarrow tests do run as part of CI and succeed on
this branch


# What changes are included in this PR?

1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests as
part of `verify-release-acndidate`


# Testing
I verified locally that `./dev/release/verify-release-candidate.sh
55.2.0 1` passes with this script

# Are there any user-facing changes?
No this is a development process only change
berkaysynnada pushed a commit to synnada-ai/arrow-rs that referenced this pull request Aug 26, 2025
…yarrow` and `parquet-variant` (apache#7745)

Note this targets a release branch, not main

I have a different proposed fix for `main`:
- apache#7742

I will also make a fix for parquet-variant test failures

# Which issue does this PR close?

- Related to apache#7394
- Related to apache#7736
- Related to apache#7746

# Rationale for this change

`cargo test --all` requires python and pyarrow installed, where it did
not in previous versions of arrow due to breaking out `arrow-pyarrow`
into its own crate in
- apache#7694

Also the new `parquet-variant` crate tests fail as part of the
verification script too -- see
ttps://github.com/apache/issues/7746


In order to get a script that can automatically verify a release
candidate, let's ignore this new module for now.

More details 
- apache#7736 
- apache#7742

Note that the arrow-pyarrow tests do run as part of CI and succeed on
this branch


# What changes are included in this PR?

1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests as
part of `verify-release-acndidate`


# Testing
I verified locally that `./dev/release/verify-release-candidate.sh
55.2.0 1` passes with this script

# Are there any user-facing changes?
No this is a development process only change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants