-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[55_maintenance] Fix verify-release-candidate.sh by skipping arrow-pyarrow and parquet-variant
#7745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrow-pyarrow and parquet-variant
brunal
approved these changes
Jun 23, 2025
Contributor
Author
|
Thanks @brunal ! |
Contributor
Author
|
I am merging this one and will make a real PR for #7746 later |
berkaysynnada
pushed a commit
to synnada-ai/arrow-rs
that referenced
this pull request
Jul 17, 2025
…yarrow` and `parquet-variant` (apache#7745) Note this targets a release branch, not main I have a different proposed fix for `main`: - apache#7742 I will also make a fix for parquet-variant test failures # Which issue does this PR close? - Related to apache#7394 - Related to apache#7736 - Related to apache#7746 # Rationale for this change `cargo test --all` requires python and pyarrow installed, where it did not in previous versions of arrow due to breaking out `arrow-pyarrow` into its own crate in - apache#7694 Also the new `parquet-variant` crate tests fail as part of the verification script too -- see ttps://github.com/apache/issues/7746 In order to get a script that can automatically verify a release candidate, let's ignore this new module for now. More details - apache#7736 - apache#7742 Note that the arrow-pyarrow tests do run as part of CI and succeed on this branch # What changes are included in this PR? 1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests as part of `verify-release-acndidate` # Testing I verified locally that `./dev/release/verify-release-candidate.sh 55.2.0 1` passes with this script # Are there any user-facing changes? No this is a development process only change
berkaysynnada
pushed a commit
to synnada-ai/arrow-rs
that referenced
this pull request
Aug 26, 2025
…yarrow` and `parquet-variant` (apache#7745) Note this targets a release branch, not main I have a different proposed fix for `main`: - apache#7742 I will also make a fix for parquet-variant test failures # Which issue does this PR close? - Related to apache#7394 - Related to apache#7736 - Related to apache#7746 # Rationale for this change `cargo test --all` requires python and pyarrow installed, where it did not in previous versions of arrow due to breaking out `arrow-pyarrow` into its own crate in - apache#7694 Also the new `parquet-variant` crate tests fail as part of the verification script too -- see ttps://github.com/apache/issues/7746 In order to get a script that can automatically verify a release candidate, let's ignore this new module for now. More details - apache#7736 - apache#7742 Note that the arrow-pyarrow tests do run as part of CI and succeed on this branch # What changes are included in this PR? 1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests as part of `verify-release-acndidate` # Testing I verified locally that `./dev/release/verify-release-candidate.sh 55.2.0 1` passes with this script # Are there any user-facing changes? No this is a development process only change
berkaysynnada
pushed a commit
to synnada-ai/arrow-rs
that referenced
this pull request
Aug 26, 2025
…yarrow` and `parquet-variant` (apache#7745) Note this targets a release branch, not main I have a different proposed fix for `main`: - apache#7742 I will also make a fix for parquet-variant test failures # Which issue does this PR close? - Related to apache#7394 - Related to apache#7736 - Related to apache#7746 # Rationale for this change `cargo test --all` requires python and pyarrow installed, where it did not in previous versions of arrow due to breaking out `arrow-pyarrow` into its own crate in - apache#7694 Also the new `parquet-variant` crate tests fail as part of the verification script too -- see ttps://github.com/apache/issues/7746 In order to get a script that can automatically verify a release candidate, let's ignore this new module for now. More details - apache#7736 - apache#7742 Note that the arrow-pyarrow tests do run as part of CI and succeed on this branch # What changes are included in this PR? 1. Exclude running the `arrow-pyarrow` and `parquet-variant` tests as part of `verify-release-acndidate` # Testing I verified locally that `./dev/release/verify-release-candidate.sh 55.2.0 1` passes with this script # Are there any user-facing changes? No this is a development process only change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this targets a release branch, not main
I have a different proposed fix for
main:pyarrowto be installed intoarrow-pyarrow-testingcrate #7742I will also make a fix for parquet-variant test failures
Which issue does this PR close?
55.2.0(June 2025) #7394test_to_pyarrowtests fail during release verification #7736parquet-variantcrate on 55.2.0 withverify-release-candidate.sh#7746Rationale for this change
cargo test --allrequires python and pyarrow installed, where it did not in previous versions of arrow due to breaking outarrow-pyarrowinto its own crate inAlso the new
parquet-variantcrate tests fail as part of the verification script too -- see ttps://github.com//issues/7746In order to get a script that can automatically verify a release candidate, let's ignore this new module for now.
More details
test_to_pyarrowtests fail during release verification #7736pyarrowto be installed intoarrow-pyarrow-testingcrate #7742Note that the arrow-pyarrow tests do run as part of CI and succeed on this branch
What changes are included in this PR?
arrow-pyarrowandparquet-varianttests as part ofverify-release-acndidateTesting
I verified locally that
./dev/release/verify-release-candidate.sh 55.2.0 1passes with this scriptAre there any user-facing changes?
No this is a development process only change