Implement DataType::{Binary, LargeBinary, BinaryView} => Variant::Binary
#8074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superserious-dev
force-pushed
the
binary-cast-to-variant
branch
from
0734d69 to
809d7ae
Compare
Contributor
|
The clippy failure was fixed in So that should be fixed by merging up from main |
alamb
approved these changes
Aug 7, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great -- thank you @superserious-dev
Contributor
|
Thanks again @superserious-dev -- I merged this so that other people working on the other types can reuse your macros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DataType::Binary/LargeBinary/BinaryViewsupport forcast_to_variantkernel #8050Rationale for this change
Adds Binary, LargeBinary, and BinaryView conversions to the cast_to_variant kernel
What changes are included in this PR?
Are these changes tested?
Yes, additional unit tests have been added.
Are there any user-facing changes?
Yes, adds new type conversions to kernel