[Parquet] Add Unbuffered writer to TrackedWrite #8548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would prefer to:
See #8534 (comment) |
|
I am fine with this, I can add |
|
I will have to add unbuffered option to the |
PiotrSrebrny
force-pushed
the
remove-BufWriter-from-TrackedWrite
branch
2 times, most recently
from
8a8361d to
da97dd1
Compare
PiotrSrebrny
changed the title
PiotrSrebrny
force-pushed
the
remove-BufWriter-from-TrackedWrite
branch
from
da97dd1 to
6496cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Are these changes tested?
Changes where not tested and should be covered by existing.
Are there any user-facing changes?
The patch removes BufWriter from TrackedWrite, thus ArrowWrite no longer wraps the provided Write with it. If the underlying writer performs poorly with small, repeated writes (e.g., a TCP socket), a user should add the BufWriter wrapping for its writer for better performance.