Add validated constructors for UnionFields #8891
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR introduces
UnionFields::try_newandUnionFields::from_fieldsas replacements for the "unsafe"UnionFields::newconstructor, which is now deprecatedPreviously,
UnionFieldscould be constructed with invalid invariants including negative type ids, duplicate type ids, or duplicate fields. SinceUnionArraysindex by type id, negative values cause panics at runtimes and duplicates break comparisons.UnionFields::try_newvalidates that type ids are non-negative, unique, under 128, and that fields are unique, returning an error if any constraint is violated.UnionFields::from_fieldsis a convenience constructor that auto-assigns sequential type ids starting from 0. (Will panic if it exceeds 128 elements)Note about reviewing
I broke it up into smaller commits. The last commit updates all call sites across the different kernels