ARROW-3158: [C++] Handle float truncation during casting #2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
commented
Sep 2, 2018
| CastOptions() | ||
| : allow_int_overflow(false), | ||
| allow_time_truncate(false), | ||
| allow_float_truncate(true) {} |
Member
Author
There was a problem hiding this comment.
True is required to keep the current behavior in the python tests.
This will be set to False by default via #2504
Member
Author
|
Thanks Uwe! |
wesm
reviewed
Sep 4, 2018
| allow_time_truncate(false), | ||
| allow_float_truncate(true) {} | ||
|
|
||
| explicit CastOptions(bool safe) |
Member
There was a problem hiding this comment.
Perhaps annotate these methods as internal / experimental. I'm not sure what will be the best way longer-term to manage these flags
wesm
pushed a commit
that referenced
this pull request
Sep 8, 2018
…safe casts Depends on both #2497 and #2503 Author: Krisztián Szűcs <[email protected]> Closes #2504 from kszucs/ARROW-2799 and squashes the following commits: 7bf9efd <Krisztián Szűcs> unsafe table creation during parquet dataset partitioning 38dfea3 <Krisztián Szűcs> disallow float truncation by default 515a393 <Krisztián Szűcs> Table.from_pandas safe option 2c82074 <Krisztián Szűcs> check-format 80e1478 <Krisztián Szűcs> lint e0838ce <Krisztián Szűcs> wire CastOptions through the API 2961094 <Krisztián Szűcs> set allow_float_truncate true by default 194e476 <Krisztián Szűcs> allow truncate float option and its implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.