GH-46098 : [C++][FlightRPC] ODBC Environment Attribute Implementation #47760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rscales <[email protected]>
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
force-pushed
the
gh-46098-sql-env-attr
branch
from
8d6f722 to
5da7b4f
Compare
lidavidm
reviewed
Oct 8, 2025
| namespace arrow::flight::sql::odbc { | ||
|
|
||
| TEST(SQLGetEnvAttr, TestSQLGetEnvAttrODBCVersion) { | ||
| // ODBC Environment |
There was a problem hiding this comment.
nit, but I don't think these comments add anything
Comment on lines
+112
to
+114
| if (!value_ptr && !str_len_ptr) { | ||
| throw DriverException("Invalid null pointer for attribute.", "HY000"); | ||
| } |
github-actions
bot
added
awaiting changes
kou
reviewed
Oct 9, 2025
Comment on lines
+19
to
+21
| #ifdef _WIN32 | ||
| # include <windows.h> | ||
| #endif |
There was a problem hiding this comment.
Should we use cpp/src/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/platform.h instead?
| // Allocate an environment handle | ||
| SQLRETURN return_env = SQLAllocEnv(&env); | ||
|
|
||
| EXPECT_EQ(SQL_SUCCESS, return_env); |
There was a problem hiding this comment.
Should we use ASSERT_EQ() not EXPECT_EQ()?
Do we need to proceed this test even when this assertion is failed?
| SQLRETURN return_set = | ||
| SQLSetEnvAttr(env, SQL_ATTR_ODBC_VERSION, reinterpret_cast<void*>(SQL_OV_ODBC2), 0); | ||
|
|
||
| EXPECT_EQ(SQL_SUCCESS, return_set); |
There was a problem hiding this comment.
Should we assert set value by SQLGetEnvAttr()?
|
|
||
| EXPECT_EQ(SQL_SUCCESS, return_env); | ||
|
|
||
| // Attempt to set to unsupported version |
Comment on lines
100
to
102
| ARROW_LOG(DEBUG) << "SQLGetEnvAttr called with env: " << env << ", attr: " << attr | ||
| << ", value_ptr: " << value_ptr << ", buffer_length: " << buffer_length | ||
| << ", str_len_ptr: " << static_cast<const void*>(str_len_ptr); |
Comment on lines
+112
to
+114
| if (!value_ptr && !str_len_ptr) { | ||
| throw DriverException("Invalid null pointer for attribute.", "HY000"); | ||
| } |
There was a problem hiding this comment.
Should we check this out of this switch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ODBC driver needs to set and get environment attributes, such as ODBC driver version.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No