-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-11683: [R] Support dplyr::mutate() #9521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeane
approved these changes
Feb 23, 2021
Member
jonkeane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I went through commit by commit which helped before going back over the full diff. A few suggestions and a few questions (making sure I am reading this correctly)
ianmcook
reviewed
Feb 23, 2021
ianmcook
reviewed
Feb 23, 2021
…or array_expressions
…k to collecting data.frame where we can't
Co-authored-by: Jonathan Keane <[email protected]>
b0bfa1c to
08f78fb
Compare
ianmcook
reviewed
Feb 24, 2021
ianmcook
reviewed
Feb 24, 2021
ianmcook
reviewed
Feb 24, 2021
ianmcook
reviewed
Feb 24, 2021
This was referenced Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps:
selected_columnsto hold field_refs instead of string column names; add code to back out the string field names where needed (e.g. datasetProject())array_refpseudo-function to do the same asfield_refforarray_expressionsdataargument toeval_array_expressionin order to bindarray_refs to the actual Arrays before evaluatingfilter()NSE code for reuse inmutate()Then:
mutate()andtransmute()(done in 578d492)Followup JIRAs: