Skip to content

Conversation

@claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Nov 2, 2025

Add timestamp logical type as described in https://s.apache.org/beam-timestamp-strategy


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Nov 2, 2025
@claudevdm claudevdm changed the title Timestam logicaltype Add timestamo logicaltype Nov 5, 2025
@claudevdm claudevdm marked this pull request as ready for review November 5, 2025 14:42
@claudevdm
Copy link
Collaborator Author

R: @ahmedabu98
R: @Abacn
R: @damccorm

@claudevdm claudevdm changed the title Add timestamo logicaltype Add timestamp logicaltype Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Timestamp logical type, which is a great addition for handling timestamps with configurable precision in Beam schemas. The implementation is solid and the accompanying tests are very thorough, covering a wide range of positive, negative, and edge cases. I have a couple of suggestions to improve the implementation's readability, maintainability, and performance, mainly around avoiding magic numbers for field access and replacing Math.pow with a more efficient alternative.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit bf19899 into apache:master Nov 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants