BIGTOP-4098: Drop python2 in bigtop-toolchain #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@iwasakims Could you help review this pr? |
Member
|
bigtop-deploy seems not to be the target here. How about update the title of PR and JIRA? |
iwasakims
changed the title
JiaLiangC
changed the title
Contributor
Author
|
@iwasakims pr title and issue already updated |
iwasakims
reviewed
Apr 28, 2024
iwasakims
reviewed
Apr 29, 2024
iwasakims
approved these changes
Apr 30, 2024
Member
iwasakims
left a comment
iwasakims
left a comment
There was a problem hiding this comment.
LGTM. Ran toolchain task on centos-7-x86_64, fedora-38-aarch64, debian-11-x86_64 and ubuntu-22.04-x86-64. Thanks, @JiaLiangC.
iwasakims
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 7f055ca)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Drop python2 in bigtop-toolchain and bigtop-deploy
The logic here includes creating a default Python. I believe the logic for creating the default Python should be handled within bigtop-deploy, so it has been removed.
How was this patch tested?
manual test
For code changes: