Skip to content

Implement new collect_source_info() method #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 23, 2025
Merged

Implement new collect_source_info() method #87

merged 14 commits into from
May 23, 2025

Conversation

@gtristan
Copy link
Contributor

@gtristan gtristan commented Mar 30, 2025

This is a sister pull request to: apache/buildstream#1997

@gtristan gtristan changed the title Implement new collect_source_info() method WIP: Implement new collect_source_info() method Mar 30, 2025
@gtristan gtristan mentioned this pull request Mar 30, 2025
Merged
@gtristan gtristan force-pushed the tristan/sboms branch 18 times, most recently from 82f87f4 to 6db2ddc Compare April 25, 2025 10:15
@gtristan gtristan changed the title WIP: Implement new collect_source_info() method Implement new collect_source_info() method Apr 25, 2025
@gtristan
Copy link
Contributor Author

gtristan commented Apr 25, 2025

This is now ready, documentation and testing and all, along with apache/buildstream#1997

@gtristan gtristan force-pushed the tristan/sboms branch 4 times, most recently from d4f0995 to 1505ae4 Compare April 27, 2025 05:32
@gtristan gtristan force-pushed the tristan/sboms branch 2 times, most recently from 189da35 to 3a444f5 Compare April 28, 2025 11:54
abderrahim
abderrahim reviewed May 1, 2025
View reviewed changes
Copy link
Contributor

@abderrahim abderrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, though I have a couple issues with the docker plugin.

@gtristan gtristan force-pushed the tristan/sboms branch 6 times, most recently from 472e3fc to 3d939e4 Compare May 7, 2025 06:20
gtristan added 14 commits May 13, 2025 17:30
@gtristan
tox.ini: Test against tristan/sboms buildstream branch
7c80720
@gtristan
sources/patch.py: Implement collect_source_info()
b7672fa
@gtristan
sources/cargo.py: Implement collect_source_info()
d3289d9
@gtristan
sources/git.py: Implement collect_source_info()
8596250
@gtristan
sources/docker.py: Implement collect_source_info()
1d55406
@gtristan
sources/bzr.py: Implement collect_source_info()
0d688cc
@gtristan
sources/pip.py: Implement collect_source_info()
32945ad
@gtristan
tests/sources/patch.py: Test patch's collect_source_info() implementa…
c498d62 
…tion
@gtristan
tests/sources/cargo.py: Test cargo's collect_source_info() implementa…
4fd134e 
…tion
@gtristan
tests/sources/git.py: Testing git's collect_source_info() implementation
88ba568
@gtristan
tests/sources/docker.py: Test docker's collect_source_info() implemen…
f9e0c15 
…tation
@gtristan
tests/sources/bzr.py: Test bzr's collect_source_info() implementation
da15f39
@gtristan
tests/sources/pip_build.py: Test pip's collect_source_info() implemen…
c3fe3e5 
…tation
@gtristan
project.conf: Update min-version to 2.5
ad3710c
@gtristan gtristan merged commit 0e4e8bd into master May 23, 2025
8 of 9 checks passed
@gtristan gtristan deleted the tristan/sboms branch May 23, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abderrahim abderrahim abderrahim left review comments

@juergbi juergbi Awaiting requested review from juergbi juergbi is a code owner

@BenjaminSchubert BenjaminSchubert Awaiting requested review from BenjaminSchubert BenjaminSchubert is a code owner

@cs-shadow cs-shadow Awaiting requested review from cs-shadow cs-shadow is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gtristan @abderrahim