Skip to content

Conversation

@bernardodemarco
Copy link
Member

Description

This PR backports #10500 to the 4.19 branch.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 15.89%. Comparing base (ee94ae5) to head (b3e1b23).
Report is 4 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/cluster/ClusterManagerImpl.java 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10653      +/-   ##
============================================
+ Coverage     15.16%   15.89%   +0.72%     
- Complexity    11328    11331       +3     
============================================
  Files          5415     5046     -369     
  Lines        474824   445164   -29660     
  Branches      57912    52706    -5206     
============================================
- Hits          72014    70765    -1249     
+ Misses       394757   366491   -28266     
+ Partials       8053     7908     -145     
Flag Coverage Δ
uitests ?
unittests 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12945

@DaanHoogland
Copy link
Contributor

@blueorangutan test

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12883)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48114 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10653-t12883-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Contributor

@rohityadavcloud , can you test this on a arm-arch-environment?

@weizhouapache weizhouapache changed the title Backport #10500 Backport #10500 framework/cluster: fix NPE for ms-host status when mgr stops Apr 9, 2025
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache merged commit d32065f into apache:4.19 Apr 9, 2025
24 of 25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants