UI: Allow editing a Running VM in an Advanced zone with security groups except for security group details #10714
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10714 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11332 11335 +3
=========================================
Files 5415 5415
Lines 474893 474892 -1
Branches 57920 57920
=========================================
+ Hits 72046 72055 +9
+ Misses 394792 394782 -10
Partials 8055 8055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
With this change, in advanced zone with Security groups, user cannot update the SGs either ? |
|
@Pearl1594 , can you explain how the check for |
|
I think the SG field is shown only if
|
|
fyi #10493 has a related change |
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13078 |
|
[SF] Trillian Build Failed (tid-13021) |
@weizhouapache I do not think that it resolves the issue. But will check. |
DaanHoogland
requested review from
kiranchavala
and removed request for
vladimirpetrov
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13213 |
|
@blueorangutan test |
|
@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
vladimirpetrov
left a comment
vladimirpetrov
left a comment
There was a problem hiding this comment.
LGTM based on manual testing.
|
[SF] Trillian test result (tid-13187)
|
8 participants
Description
This PR allows users to update VM name, etc of a VM in running state deployed in an advanced zone with security groups.
The form isn't pre-populated with the existing SG of the VM as doing so causes the API to send the securitygroupids of what is already set on the VM to the backend and that leads to the editVM operation failing as it believes that the SG is being attempted to be modified.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?