-
Notifications
You must be signed in to change notification settings - Fork 1.2k
only clean details and annotations when this template no longer exists #10728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only clean details and annotations when this template no longer exists #10728
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10728 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11332 11333 +1
=========================================
Files 5415 5415
Lines 474893 474898 +5
Branches 57920 57920
=========================================
+ Hits 72046 72049 +3
- Misses 394792 394795 +3
+ Partials 8055 8054 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13063 |
|
@blueorangutan test |
|
@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
kiranchavala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Tested the issue manually
- Have cloudstack env with 2 zones
- Register a template a zone 1
- Add template setting UEFI=secure
- Copy the template to zone 2
- Delete the template in zone2
The template setting is still persisted on Zone 1
|
[SF] Trillian Build Failed (tid-13036) |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
… on any zone
Description
This PR...
Fixes: #10600
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?