kvm: add ssvm storage nic null uri check during plug

[shwstppr]

Description

Fixes #11552

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (973b333) to head (9e2e8c9).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...cloud/hypervisor/kvm/resource/BridgeVifDriver.java	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11557   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13287    13289    +2     
=========================================
  Files          5656     5656           
  Lines        498008   498020   +12     
  Branches      60404    60405    +1     
=========================================
+ Hits          80541    80550    +9     
- Misses       408505   408508    +3     
  Partials       8962     8962           

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	17.02% <84.61%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[weizhouapache]

@shwstppr
I modified the target branch to 4.20

[weizhouapache]

code lgtm

[sureshanaparti]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14819

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14194)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53178 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11557-t14194-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[shwstppr]

Refactored and added tests

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[shwstppr]

The change that is causing issue #11552 went into 4.19, @weizhouapache are you okay if I rebase this to 4.19 or is that not needed considering 4.19 is EOL?

[weizhouapache]

The change that is causing issue #11552 went into 4.19, @weizhouapache are you okay if I rebase this to 4.19 or is that not needed considering 4.19 is EOL?

@shwstppr
I think 4.20 is good for this PR

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14842

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14227)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54531 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11557-t14227-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_10_reboot_cpvm_forced	Failure	963.30	test_ssvm.py

[weizhouapache]

tested by
https://lists.apache.org/thread/8gd4179nq43lzd05h6gf6g23fq3k5yxo

[daviftorres]

Hey @weizhouapache , I see that this PR is in the milestone of 4.20.2 but it fixed a bug reported on 4.21.0. It is not intuitive for me. Could you please clarify how this development process works?

[weizhouapache]

Hey @weizhouapache , I see that this PR is in the milestone of 4.20.2 but it fixed a bug reported on 4.21.0. It is not intuitive for me. Could you please clarify how this development process works?

@daviftorres
all 4.20 commits will be merged into 4.21

[weizhouapache]

For those who face the issue after upgrading to 4.21.0.0

• backup /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.21.0.0.jar
• download file
  cloud-plugin-hypervisor-kvm-4.21.0.0.zip
• move to /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.21.0.0.jar
• systemctl restart cloudstack-agent

[daviftorres]

It works like a charm! Good job!!