added constant for magic code

[vcharmcaster]

"=" was used in lots of space extracted it as constant

[syed]

Looks like there are some trailing space problems. Can you please fix that @vcharmcaster

/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:25: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:26:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:27:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:28:1: error: Line contains a tab character.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29: error: Line has trailing spaces.
/home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java:29:1: error: Line contains a tab character.

Also, can you rebase your commits into a single commit?

Otherwise, the code LGTM 👍

[swill]

Should the result of the splits be stripped of whitespace to make sure there is no extra whitespace being saved into variables?

[vcharmcaster]

@swill @syed updated formatting. Let me know if i missed something.

[syed]

@vcharmcaster it looks like your commit still did not fix the problems. Can you check the problems I mentioned in my previous comments. There are some trailing spaces and tabs which need to be fixed.

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1597

[blueorangutan]

Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1597
Job ID #66

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-212

[rohityadavcloud]

@vcharmcaster can you fix the space/tab issue.

[fmaximus]

Could be also simplified to paramTokens[0]

[fmaximus]

Could be also simplified to paramTokens[1]

[DaanHoogland]

@vcharmcaster please rebase and re-open if still relevant

@GabrielBrascher is this still relevant?