Mocking the Connect object used in the LibvirtMigrateCommandWrapper. #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When executing the tests in an environment where Libvirt is also installed, it caused errors.
Contributor
|
LGTM :D |
|
cloudstack-pull-requests #285 SUCCESS |
Member
|
Travis is green, merging now. |
Member
|
@rsafonseca oh wait, since you testing it. I'll wait for you to come back. |
Contributor
|
[INFO] Apache CloudStack Plugin - Hypervisor KVM ......... SUCCESS [6.987s] Perfect :) |
Contributor
Author
|
Awesome!!! :) Thanks for testing. @roh it: could you please merge it? :) Cheers, Sent from my iPhone On 01 Jun 2015, at 20:25, Rafael da Fonseca <[email protected]mailto:[email protected]> wrote: [INFO] Apache CloudStack Plugin - Hypervisor KVM ......... SUCCESS [6.987s] Perfect :) — |
Member
|
@wilderrodrigues done, merged on master. |
rohityadavcloud
added a commit
that referenced
this pull request
Jan 20, 2021
Fixes #342 - Fix the project name to show currently selected project - Reload project list of focus/clicking - Fix icon size - Remove code Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bhaisaab and @rsafonseca,
The Connect class is now being mocked, which means it will not load any native library.
Build environment:
[root@kvm3 cloudstack]# uname -a
Linux kvm3 3.10.0-229.1.2.el7.x86_64 #1 SMP Fri Mar 27 03:04:26 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
[root@kvm3 cloudstack]# cat /etc/centos-release
CentOS Linux release 7.1.1503 (Core)
[root@kvm3 cloudstack]# virsh --version=long
Virsh command line tool of libvirt 1.2.8
See web site at http://libvirt.org/
Compiled with support for:
Hypervisors: QEMU/KVM LXC ESX Test
Networking: Remote Network Bridging Interface netcf Nwfilter VirtualPort
Storage: Dir Disk Filesystem SCSI Multipath iSCSI LVM Gluster
Miscellaneous: Daemon Nodedev SELinux Secrets Debug DTrace Readline Modular
Command executed: mvn -P developer,systemvm clean install
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:50.546s
[INFO] Finished at: Mon Jun 01 09:04:28 EDT 2015
[INFO] Final Memory: 103M/671M
[INFO] ------------------------------------------------------------------------
[root@kvm3 cloudstack]#
Cheers,
Wilder