Skip to content

Conversation

@havengit
Copy link
Contributor

@havengit havengit commented May 8, 2020

Description

Issue present in cloudstack 4.13.1.0, 4.14.0.0-RC2
When Guest VM add secondary nic, will get wrong hostname "infiniteh" from dhcp server
infiniteh -->infinite
cat /etc/dhcphosts.txt
02:00:0b:ef:00:04,set:192_168_4_18,192.168.4.18,gumd-tes3,infiniteh

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

When Guest VM add secondary nic,  will get wrong hostname "infiniteh" from dhcp server
infiniteh -->infinite
cat /etc/dhcphosts.txt
02:00:0b:ef:00:04,set:192_168_4_18,192.168.4.18,gumd-tes3,infiniteh
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔debian. JID-1219

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@andrijapanicsb
Copy link
Contributor

Does this warrant an RC3 for 4.14?
It's a valid fix by all means, but would prolong the voting again.
Shall I cut RC3 tonight? @DaanHoogland @rhtyd @weizhouapache

@blueorangutan
Copy link

Trillian test result (tid-1516)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42845 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4064-t1516-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_delete_kubernetes_supported_version Error 1807.51 test_kubernetes_supported_versions.py

@rohityadavcloud
Copy link
Member

@andrijapanicsb I'm okay to cut RC3 if there are not further blockers requiring a RC cc @DaanHoogland

@andrijapanicsb andrijapanicsb merged commit 60d7215 into apache:master May 11, 2020
@DaanHoogland DaanHoogland mentioned this pull request May 18, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants