Skip to content

novnc: Hide fullscreen button when not connected #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

novnc: Hide fullscreen button when not connected #4783

merged 1 commit into from
Mar 17, 2021

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Mar 10, 2021

Description

Hides the fullscreen button in novnc until connected to the VM
This prevents the UI.rfb is not initialized error

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

Screenshot from 2021-03-10 12-30-17
Screenshot from 2021-03-10 12-30-22

After

Screenshot from 2021-03-10 12-29-34

@davidjumani
Copy link
Contributor Author

davidjumani commented Mar 10, 2021

@blueorangutan package

@davidjumani davidjumani mentioned this pull request Mar 10, 2021
Merged
5 tasks
@davidjumani davidjumani changed the base branch from master to 4.15 March 10, 2021 07:18
@weizhouapache
Copy link
Member

weizhouapache commented Mar 10, 2021

@davidjumani good, I will test it

@davidjumani
Copy link
Contributor Author

davidjumani commented Mar 10, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 10, 2021

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok.

@blueorangutan
Copy link

blueorangutan commented Mar 10, 2021

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2893

shwstppr
shwstppr approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link

blueorangutan commented Mar 10, 2021

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 70

@DaanHoogland DaanHoogland added this to the 4.15.1.0 milestone Mar 11, 2021
@shwstppr
Copy link
Contributor

shwstppr commented Mar 17, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 17, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Mar 17, 2021

Changes are in CSS only, won't need to be checked by marvin tests. Travis passes so we can merge.

@rohityadavcloud rohityadavcloud merged commit c2b378c into apache:4.15 Mar 17, 2021
@blueorangutan
Copy link

blueorangutan commented Mar 17, 2021

Packaging result: ✔️ centos7 ✔️ centos8 ✖️ debian. SL-JID 150

DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022
@davidjumani
novnc: Hide fullscreen button when not connected (apache#4783)
bc2c40b
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 17, 2023
@davidjumani @shwstppr
novnc: Hide fullscreen button when not connected (apache#4783)
b406e65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:console-proxy type:bug

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@davidjumani @weizhouapache @blueorangutan @shwstppr @rohityadavcloud @DaanHoogland