Skip to content

Conversation

@utchoang
Copy link

Description

Fixes #5166

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5167 (SL-JID-298)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM
Minor suggestion if we want to address #4956 these changes can be modified to
let path = this.prefillContent.primaryStoragePath?.value || ''

@davidjumani
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5167 (SL-JID-304)

@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Jul 5, 2021
@rohityadavcloud
Copy link
Member

LGTM

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti
Copy link
Contributor

Merging this based on approvals, and reviews.

@sureshanaparti sureshanaparti merged commit f7cc3c9 into apache:main Jul 9, 2021
@utchoang utchoang deleted the feature/fix-zone-wizard-primary-storage branch July 12, 2021 07:36
@nvazquez nvazquez mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Cannot use RBD primary storage when adding ZONE

7 participants