Fix linux native bridge for SUSE in cloudutils #6134

mib1185 · 2022-03-17T14:18:37Z

Description

This PR fixes Can't setup OpenSUSE KVM host with linux native bridge #6112

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2022-03-17T15:34:20Z

@blueorangutan package

blueorangutan · 2022-03-17T15:36:04Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

rohityadavcloud

Lgtm needs testing

mib1185 · 2022-03-17T15:54:26Z

Lgtm needs testing

Have tested it in my test environment, but would like to see this working in your Trilian test system :)

blueorangutan · 2022-03-17T16:40:12Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2919

DaanHoogland · 2022-03-17T16:55:31Z

@blueorangutan help

blueorangutan · 2022-03-17T16:56:03Z

@DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu20', 'rocky8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache', 'NuxRo']

DaanHoogland · 2022-03-17T17:03:34Z

@blueorangutan test suse15 kvm-suse15 keepEnv

blueorangutan · 2022-03-17T17:05:03Z

@DaanHoogland a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

mib1185 · 2022-03-17T20:00:34Z

@DaanHoogland does the kvm-suse15 use ovs oder Linux native bridge?

davidjumani · 2022-03-18T05:48:44Z

@mib1185 It uses Linux bridges, however they are preconfigured before installing the cloudstack agent

python/lib/cloudutils/serviceConfig.py

blueorangutan · 2022-03-18T07:05:59Z

Trillian test result (tid-3655)
Environment: kvm-suse15 (x2), Advanced Networking with Mgmt server s15
Total time taken: 48839 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6134-t3655-kvm-suse15.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.48	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.10	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.19	test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	29.90	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	75.96	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	71.75	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	73.47	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	`Error`	154.32	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	49.26	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	225.67	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	265.69	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	142.77	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	43.71	test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.42	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.42	test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	303.88	test_hostha_kvm.py

davidjumani · 2022-03-18T07:10:09Z

Can run cloudstack-setup-agent with this fix. Since this doesn't affect any features, smoke tests can be ignored

nvazquez · 2022-03-19T03:24:56Z

@blueorangutan test suse15 kvm-suse15 keepEnv

blueorangutan · 2022-03-19T03:26:03Z

@nvazquez a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

blueorangutan · 2022-03-19T16:34:30Z

Trillian test result (tid-3672)
Environment: kvm-suse15 (x2), Advanced Networking with Mgmt server s15
Total time taken: 45629 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6134-t3672-kvm-suse15.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	152.22	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	50.27	test_vm_life_cycle.py

nvazquez · 2022-03-22T01:07:00Z

@blueorangutan package

blueorangutan · 2022-03-22T01:08:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-22T01:43:28Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2950

davidjumani · 2022-03-22T04:47:20Z

No need to run smoke tests

nvazquez · 2022-03-22T11:39:01Z

Hi @mib1185 thanks for the fix - could you please target it for the branch 4.16?

mib1185 · 2022-03-22T12:12:03Z

rebase and re-targeting done

nvazquez · 2022-03-22T12:38:43Z

Thanks @mib1185 kicking new packages
@blueorangutan package

davidjumani · 2022-03-22T12:59:01Z

@blueorangutan package

blueorangutan · 2022-03-22T13:22:04Z

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-22T13:56:19Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2957

nvazquez · 2022-03-22T14:10:24Z

Thanks @mib1185 - have marked it as a draft PR to prevent merging before our testing concludes

* fix linux native bridge for SUSE * apply suggestion (cherry picked from commit fb43076) Signed-off-by: Rohit Yadav <[email protected]>

mib1185 changed the title ~~Ffix linux native bridge for SUSE in cloudutils~~ Fix linux native bridge for SUSE in cloudutils Mar 17, 2022

rohityadavcloud approved these changes Mar 17, 2022

View reviewed changes

nvazquez added this to the 4.17.0.0 milestone Mar 18, 2022

nvazquez added type:bug Severity:BLOCKER labels Mar 18, 2022

davidjumani reviewed Mar 18, 2022

View reviewed changes

python/lib/cloudutils/serviceConfig.py Outdated Show resolved Hide resolved

davidjumani approved these changes Mar 22, 2022

View reviewed changes

nvazquez approved these changes Mar 22, 2022

View reviewed changes

mib1185 added 2 commits March 22, 2022 13:04

fix linux native bridge for SUSE

3e88a61

apply suggestion

d3ef562

mib1185 force-pushed the patch-1 branch from 5ef7490 to d3ef562 Compare March 22, 2022 12:10

mib1185 changed the base branch from main to 4.16 March 22, 2022 12:10

nvazquez marked this pull request as draft March 22, 2022 14:03

nvazquez marked this pull request as ready for review March 23, 2022 16:42

nvazquez merged commit fb43076 into apache:4.16 Mar 23, 2022

mib1185 deleted the patch-1 branch March 23, 2022 17:18

Fix linux native bridge for SUSE in cloudutils #6134

Fix linux native bridge for SUSE in cloudutils #6134

Uh oh!

Conversation

mib1185 commented Mar 17, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Mar 17, 2022

Uh oh!

blueorangutan commented Mar 17, 2022

Uh oh!

rohityadavcloud left a comment

Choose a reason for hiding this comment

Uh oh!

mib1185 commented Mar 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Mar 17, 2022

Uh oh!

DaanHoogland commented Mar 17, 2022

Uh oh!

blueorangutan commented Mar 17, 2022

Uh oh!

DaanHoogland commented Mar 17, 2022

Uh oh!

blueorangutan commented Mar 17, 2022

Uh oh!

mib1185 commented Mar 17, 2022

Uh oh!

davidjumani commented Mar 18, 2022

Uh oh!

Uh oh!

blueorangutan commented Mar 18, 2022

Uh oh!

davidjumani commented Mar 18, 2022

Uh oh!

nvazquez commented Mar 19, 2022

Uh oh!

blueorangutan commented Mar 19, 2022

Uh oh!

blueorangutan commented Mar 19, 2022

Uh oh!

nvazquez commented Mar 22, 2022

Uh oh!

blueorangutan commented Mar 22, 2022

Uh oh!

blueorangutan commented Mar 22, 2022

Uh oh!

davidjumani commented Mar 22, 2022

Uh oh!

nvazquez commented Mar 22, 2022

Uh oh!

mib1185 commented Mar 22, 2022

Uh oh!

nvazquez commented Mar 22, 2022

Uh oh!

davidjumani commented Mar 22, 2022

Uh oh!

blueorangutan commented Mar 22, 2022

Uh oh!

blueorangutan commented Mar 22, 2022

Uh oh!

nvazquez commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mib1185 commented Mar 17, 2022 •

edited

Loading