kvm: truncate vnc password to 8 chars #6244

weizhouapache · 2022-04-11T18:23:00Z

Description

This PR truncates the vnc password of kvm vms to 8 chars.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2022-04-11T18:23:54Z

this requires manually testing on ubuntu 22.04 or libvirt 8. I will not sure if novnc console works

nvazquez · 2022-04-12T02:44:01Z

@blueorangutan package

blueorangutan · 2022-04-12T02:47:02Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-12T03:24:05Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3132

weizhouapache · 2022-04-12T07:58:38Z

@blueorangutan package

blueorangutan · 2022-04-12T07:59:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2022-04-12T08:09:17Z

tested on centos7 and ubuntu20, vm console works.

I have not tested on ubuntu 22.04.

blueorangutan · 2022-04-12T08:30:49Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3136

rohityadavcloud · 2022-04-12T09:24:07Z

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

            }
            if (_passwd != null) {
-                graphicBuilder.append(" passwd='" + _passwd + "'");
+                graphicBuilder.append(" passwd='" + StringUtils.truncate(_passwd, 8) + "'");


Why is that @weizhouapache ? Does this fix/address any libvirt limitation or user reported issue?

@rohityadavcloud
this aims to fix an issue with ubuntu 22.04 (to be released soon) and libvirt 8.
the issue is raised in mailing list: https://lists.apache.org/thread/zk4fyggjqk1zphk4dfg1m596yrd15d9b

from many years ago, libvirt accepts vnc password with more than 8 chars. but only the first 8 chars in vnc password are used in vnc console verification (the other chars are dropped).
In recent libvirt, only vnc password with 8 chars is permitted.

…-password-8-chars

weizhouapache · 2022-04-12T10:10:54Z

@blueorangutan package

blueorangutan · 2022-04-12T10:14:02Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2022-04-12T10:38:01Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 3141

weizhouapache · 2022-04-12T10:58:38Z

@blueorangutan package

blueorangutan · 2022-04-12T10:59:02Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2022-04-12T11:25:48Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3143

nvazquez · 2022-04-12T12:47:16Z

@blueorangutan test

blueorangutan · 2022-04-12T12:48:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-12T12:58:52Z

Trillian Build Failed (tid-3871)

nvazquez · 2022-04-12T16:16:54Z

@blueorangutan test

blueorangutan · 2022-04-12T16:18:04Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-13T01:02:39Z

Trillian test result (tid-3879)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30158 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3879-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py

nvazquez · 2022-04-13T02:57:37Z

@blueorangutan test

blueorangutan · 2022-04-13T02:58:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-13T12:33:20Z

Trillian test result (tid-3884)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33260 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3884-kvm-centos7.zip
Smoke tests completed. 88 look OK, 5 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.56	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.10	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.19	test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	28.83	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	52.20	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	37.91	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	35.95	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	124.61	test_kubernetes_clusters.py
test_01_secure_vm_migration	`Error`	149.24	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	274.11	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	143.78	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	43.78	test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.43	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.43	test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	305.93	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	9.27	test_hostha_kvm.py

nvazquez · 2022-04-13T12:37:50Z

@blueorangutan test

blueorangutan · 2022-04-13T12:39:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-13T22:08:29Z

Trillian test result (tid-3895)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32789 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6244-t3895-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2022-04-14T17:41:47Z

@blueorangutan package

blueorangutan · 2022-04-14T17:43:04Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-14T18:29:56Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3176

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt. (cherry picked from commit aa0197c) Signed-off-by: Rohit Yadav <[email protected]>

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt. Backport of apache@aa0197c Signed-off-by: Rohit Yadav <[email protected]>

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt. (cherry picked from commit aa0197c) Signed-off-by: Rohit Yadav <[email protected]>

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* kvm: truncate vnc password to 8 chars (#6244) This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt. * Use lang3 string utils Co-authored-by: Wei Zhou <[email protected]>

…#6402) * kvm: truncate vnc password to 8 chars (apache#6244) This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt. * Use lang3 string utils Co-authored-by: Wei Zhou <[email protected]>

* Extract the IO_URING configuration into the agent.properties (apache#6253) When using advanced virtualization the IO Driver is not supported. The admin will decide if want to enable/disable this configuration from agent.properties file. The default value is true * kvm: truncate vnc password to 8 chars (apache#6244) This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt. * merge fix Signed-off-by: Abhishek Kumar <[email protected]> * [KVM] Enable IOURING only when it is available on the host (apache#6399) * [KVM] Disable IOURING by default on agents * Refactor * Remove agent property for iouring * Restore property * Refactor suse check and enable on ubuntu by default * Refactor irrespective of guest OS * Improvement * Logs and new path * Refactor condition to enable iouring * Improve condition * Refactor property check * Improvement * Doc comment * Extend comment * Move method * Add log * [KVM] Fix VM migration error due to VNC password on libvirt limiting versions (apache#6404) * [KVM] Fix VM migration error due to VNC password on libvirt limiting versions * Fix passwd value * Simplify implementation Co-authored-by: slavkap <[email protected]> Co-authored-by: Wei Zhou <[email protected]> Co-authored-by: Nicolas Vazquez <[email protected]>

kvm: truncate vnc password to 8 chars

4e7348f

boring-cyborg bot added the component:kvm label Apr 11, 2022

nvazquez approved these changes Apr 12, 2022

View reviewed changes

weizhouapache changed the base branch from 4.16 to main April 12, 2022 07:58

rohityadavcloud reviewed Apr 12, 2022

View reviewed changes

Merge remote-tracking branch 'apache/main' into 4.16-kvm-truncate-vnc…

0c21b71

…-password-8-chars

Update apache#6244: fix unit tests

020b614

weizhouapache added this to the 4.17.0.0 milestone Apr 14, 2022

weizhouapache marked this pull request as ready for review April 14, 2022 17:41

rohityadavcloud approved these changes Apr 15, 2022

View reviewed changes

rohityadavcloud merged commit aa0197c into apache:main Apr 15, 2022

weizhouapache mentioned this pull request Apr 22, 2022

unsupported configuration: VNC password is 22 characters long, only 8 permitted #6302

Closed

weizhouapache mentioned this pull request May 18, 2022

KVM NFS disk IO driver supporting IO_URING #5012

Merged

5 tasks

nvazquez pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022

kvm: truncate vnc password to 8 chars (apache#6244)

99c69a4

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

nvazquez mentioned this pull request May 20, 2022

Backport: kvm: truncate vnc password to 8 chars (#6244) #6402

Merged

12 tasks

weizhouapache deleted the 4.16-kvm-truncate-vnc-password-8-chars branch December 9, 2022 08:38

kvm: truncate vnc password to 8 chars #6244

kvm: truncate vnc password to 8 chars #6244

Uh oh!

Conversation

weizhouapache commented Apr 11, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Apr 11, 2022

Uh oh!

nvazquez commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

weizhouapache commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

weizhouapache commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

rohityadavcloud Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

weizhouapache Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

rohityadavcloud Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

weizhouapache commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

nvazquez commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

nvazquez commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 12, 2022

Uh oh!

blueorangutan commented Apr 13, 2022

Uh oh!

nvazquez commented Apr 13, 2022

Uh oh!

blueorangutan commented Apr 13, 2022

Uh oh!

blueorangutan commented Apr 13, 2022

Uh oh!

nvazquez commented Apr 13, 2022

Uh oh!

blueorangutan commented Apr 13, 2022

Uh oh!

blueorangutan commented Apr 13, 2022

Uh oh!

weizhouapache commented Apr 14, 2022

Uh oh!

blueorangutan commented Apr 14, 2022

Uh oh!

blueorangutan commented Apr 14, 2022

Uh oh!