Skip to content

Conversation

@weizhouapache
Copy link
Member

Description

This PR fixes #6727

The start of guest vlan range is a must.
if end is not set, the vlan range is start-start
otherwise, the vlan range is start-end

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Start and end are not set.
image

Start is set
image

wrong range
image

correct range
image

How Has This Been Tested?

@weizhouapache weizhouapache added this to the 4.18.0.0 milestone Jan 2, 2023
@weizhouapache weizhouapache linked an issue Jan 2, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #7038 (d8cdbde) into 4.17 (d5f0100) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7038   +/-   ##
=========================================
  Coverage     10.36%   10.36%           
- Complexity     6630     6631    +1     
=========================================
  Files          2453     2453           
  Lines        242386   242386           
  Branches      37928    37928           
=========================================
+ Hits          25120    25129    +9     
+ Misses       214158   214148   -10     
- Partials       3108     3109    +1     
Impacted Files Coverage Δ
...rg/apache/cloudstack/quota/QuotaStatementImpl.java 40.26% <0.00%> (+3.98%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7038 (QA-JID-24)

@DaanHoogland DaanHoogland merged commit e8aff6f into apache:4.17 Jan 3, 2023
DaanHoogland added a commit that referenced this pull request Jan 4, 2023
* 4.17:
  UI: user must specify the start of guest vlan range for advanced zone (#7038)
@weizhouapache weizhouapache deleted the 4.17-force-guest-vlan-start branch January 5, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem With Creating Isolated Network

4 participants