linstor: resize root disk on offerings with different size

[rp-]

Description

This fixes the root disk from templates not resized by Linstor if the compute offering specifies a different
root disk size. Also described in the linked issue.

It would also be good if this could merged into a 4.18. bugfix release.

Fixes: #7934

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Local cloudstack cluster with Linstor as primary storage.

[codecov]

Codecov Report

Merging #7952 (ba44a93) into 4.18 (f049f54) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #7952      +/-   ##
============================================
- Coverage     13.06%   13.06%   -0.01%     
  Complexity     9097     9097              
============================================
  Files          2720     2720              
  Lines        257465   257470       +5     
  Branches      40145    40146       +1     
============================================
  Hits          33635    33635              
- Misses       219603   219608       +5     
  Partials       4227     4227              

Files Changed	Coverage Δ
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rohityadavcloud]

@rp- can you raise this on 4.18 branch?

[rp-]

@rohityadavcloud done

[rohityadavcloud]

Thanks @rp-
@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7017

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7669)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45402 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7952-t7669-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	3649.39	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.07	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	293.59	test_kubernetes_clusters.py

[DaanHoogland]

clgtm

[DaanHoogland]

insanity:
@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7684)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47724 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7952-t7684-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	701.81	test_kubernetes_clusters.py

[rohityadavcloud]

LGTM - didn't test it yet, can confirm testing by next weekend (my test gear needs new disks to test a fresh linstor cluster)

[rp-]

will this also cherry-picked into 4.19.?

[DaanHoogland]

:) patience my young paduan