Fix 2FA becoming enabled when the user inputs the wrong code during setup

[winterhazel]

Description

During the 2FA setup, the user must input a code in order to verify the configuration. If the user inserts the wrong code, an error message is shown; however, 2FA still gets enabled.

This PR fixes this behavior and prevents 2FA from becoming enabled if the user inserts the wrong code.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

In a local lab:

• In a user of the root admin account, I opened the 2FA setup, selected static PIN, provided the wrong PIN and verified that 2FA did not get enabled;
• In a user of the root admin account, I opened the 2FA setup, selected static PIN, provided the correct PIN and verified that 2FA was enabled;
• In a user of a non-admin account belonging to domain test/test2, I opened the 2FA setup, selected static PIN, provided the wrong PIN and verified that 2FA did not get enabled.
• In a user of a non-admin account belonging to domain test/test2, I opened the 2FA setup, selected static PIN, provided the correct PIN and verified that 2FA was enabled.

[codecov]

Codecov Report

Merging #7972 (e1501ad) into 4.18 (9c9b178) will not change coverage.
Report is 1 commits behind head on 4.18.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               4.18    #7972   +/-   ##
=========================================
  Coverage     13.06%   13.06%           
  Complexity     9102     9102           
=========================================
  Files          2720     2720           
  Lines        257469   257469           
  Branches      40146    40146           
=========================================
  Hits          33638    33638           
  Misses       219605   219605           
  Partials       4226     4226           

Files Changed	Coverage Δ
...c/main/java/com/cloud/user/AccountManagerImpl.java	20.47% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7059

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7691)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44451 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7972-t7691-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_destroy_ssvm	Failure	910.80	test_ssvm.py

[shwstppr]

Code LGTM

[rohityadavcloud]

ping @harikrishna-patnala can you review this?

[harikrishna-patnala]

agreed, code LGTM

[harikrishna-patnala]

reproduced the issue and verified the fix, it is looking good. Thanks @rohityadavcloud

[GutoVeronezi]

Thanks for the fix, @winterhazel.