add procedures procedure

[DaanHoogland]

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 1.23457% with 80 lines in your changes missing coverage. Please review.

Project coverage is 15.07%. Comparing base (54c8b71) to head (2925511).

Files	Patch %	Lines
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java	1.23%	80 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9385      +/-   ##
============================================
- Coverage     15.07%   15.07%   -0.01%     
  Complexity    11169    11169              
============================================
  Files          5405     5405              
  Lines        472677   472708      +31     
  Branches      60049    61718    +1669     
============================================
+ Hits          71269    71271       +2     
- Misses       393479   393509      +30     
+ Partials       7929     7928       -1     

Flag	Coverage Δ
uitests	4.27% <ø> (ø)
unittests	15.79% <1.23%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GutoVeronezi]

Nice work @DaanHoogland!

I believe we could do the same for the cloud_usage stored procedures.

Should we separate the cloud_usage in different files?

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10344

[DaanHoogland]

Nice work @DaanHoogland!

I believe we could do the same for the cloud_usage stored procedures.

Should we separate the cloud_usage in different files?

I thought of that but wanted to check versions against each other. I will make that change.

A change I won't make but what we need to do in another PR is cleaning the views from the schema update files. I encoutered a couple.

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10821)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43258 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9385-t10821-kvm-centos7.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	Failure	173.39	test_cluster_drs.py

[DaanHoogland]

@blueorangutan test matrix

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10828)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45251 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9385-t10828-xenserver-71.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10364

[DaanHoogland]

@blueorangutan test matrix

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-10849)

[GutoVeronezi]

Nice work @DaanHoogland!
I believe we could do the same for the cloud_usage stored procedures.
Should we separate the cloud_usage in different files?

I thought of that but wanted to check versions against each other. I will make that change.

@DaanHoogland
I was thinking a little bit more about this, and, except for ADD_GUEST_OS_AND_HYPERVISOR_MAPPING, the other procedures are valid for both cloud and cloud_usage. Perhaps we could execute the script once for each schema instead of duplicating the code. What do you think?

[DaanHoogland]

Nice work @DaanHoogland!
I believe we could do the same for the cloud_usage stored procedures.
Should we separate the cloud_usage in different files?

I thought of that but wanted to check versions against each other. I will make that change.

@DaanHoogland I was thinking a little bit more about this, and, except for ADD_GUEST_OS_AND_HYPERVISOR_MAPPING, the other procedures are valid for both cloud and cloud_usage. Perhaps we could execute the script once for each schema instead of duplicating the code. What do you think?

that sounds good, but so far creating envs with this code doesn't work. I am not sure why yet, but giving that priority.

(will keep it in mind though)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10386

[blueorangutan]

[SF] Trillian Build Failed (tid-10900)

[blueorangutan]

[SF] Trillian Build Failed (tid-10904)

[blueorangutan]

[SF] Trillian Build Failed (tid-10908)

[blueorangutan]

[LL] Trillian Build Failed (tid-6958)

[blueorangutan]

[SF] Trillian Build Failed (tid-10918)

[blueorangutan]

[SF] Trillian Build Failed (tid-10921)

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10415

[blueorangutan]

[SF] Trillian test result (tid-10927)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 52176 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9385-t10927-kvm-alma8.zip
Smoke tests completed. 131 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	Failure	527.03	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	527.05	test_vpc_redundant.py

[DaanHoogland]

@GutoVeronezi i got this working and did some investigating on iterating over databases but all solutions so far seem overcomplicated. Let's revisist later, ok?

[blueorangutan]

[SF] Trillian test result (tid-10936)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43631 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9385-t10936-kvm-centos7.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

code lgtm

just a tip for those who want to create the procedures manually
the SQLs do not work in mysql CLI as the default delimiter is ";", need to change to other value like "||"

DROP PROCEDURE IF EXISTS ...

DELIMITER ||

CREATE PROCEDURE ...
||

DELIMITER ;

[vladimirpetrov]

LGTM based on manual testing, I did some upgrade and smoke testing and found no issues.