-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update project account for all the events with project account owner, except for create project event #9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project account for all the events with project account owner, except for create project event #9572
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9572 +/- ##
==========================================
Coverage 15.08% 15.08%
- Complexity 11181 11184 +3
==========================================
Files 5406 5406
Lines 472915 473067 +152
Branches 58400 58992 +592
==========================================
+ Hits 71336 71381 +45
- Misses 393637 393744 +107
Partials 7942 7942
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10755 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10760 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10761 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11146)
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10808 |
rajujith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Project events are visible in the default view and project view as expected. Events 'completed' are also visible.
… except for create project event (apache#9572)
Description
This PR updates the project account (which is the resource owner id rather than the calling user account id) for all the events with project account owner, except for create project event.
Project events are not missed, but calling account is added to scheduled events and project account is added to started, completed events. So, some of the events for the operation are in Default view and others in project View, which is confusing. This PR keeps project account for all events with with project account except for create project event.
Fixes #9432
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Manually performed below operations and checked the events before & after fix.
(i) Create project
(ii) Add account to project
(iii) Add user to project from the account in step (ii) - will Fail
(iv) Add user to project from another account.
Before Fix =>
Default View Events:
Project View Events:
Project Events DB:
After Fix =>
Default View Events:
Project View Events:
Project Events DB:
How did you try to break this feature and the system with this change?