fix: better int96 support for experimental native scans #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stamps in native_datafusion experimental Parquet scan.
mbutrovich
changed the title
# Conflicts: # native/Cargo.lock # native/Cargo.toml # native/core/Cargo.toml # native/core/src/parquet/parquet_support.rs
|
This should be ready for review now that #1563 merged. I am investigating an issue with complex types and int96 that prevents me from enabling the fuzz test for int96. |
andygrove
approved these changes
Apr 17, 2025
|
I opened an issue for nested INT96. For now we'll keep the CometFuzzTestSuite, I will open a PR early next week to re-enable just for primitive type schemas, and then work on the fix. |
kazuyukitanimura
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially address #1441. Fixes 3 more test cases.
Rationale for this change
Better support for Parquet INT96 data that originated from Spark 64-bit microsecond timestamps.
What changes are included in this PR?
Most of the changes were in dependencies:
This PR just enables the new feature that was added in the PRs above.
How are these changes tested?
Re-enable 4 Comet tests for the native readers.