-
Notifications
You must be signed in to change notification settings - Fork 246
Feat: Add sha1 function impl #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kazantsev-maksim starting CI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
============================================
+ Coverage 56.12% 59.01% +2.89%
- Complexity 976 1457 +481
============================================
Files 119 146 +27
Lines 11743 13572 +1829
Branches 2251 2359 +108
============================================
+ Hits 6591 8010 +1419
- Misses 4012 4341 +329
- Partials 1140 1221 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # native/core/src/execution/jni_api.rs
inputs: Seq[Attribute], | ||
binding: Boolean): Option[ExprOuterClass.Expr] = { | ||
if (!HashUtils.isSupportedType(expr)) { | ||
return None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets return a fallback reason like
if (!isTypeSupported(dt)) {
withInfo(expr, s"data type not supported: $dt")
return None
}
@kazantsev-maksim I took the liberty to modify the PR, waiting the CI |
@comphead do you have any ideas what the problem might be? I couldn't reproduce the problem on my local machine... |
Which issue does this PR close?
Part of: #2443
Rationale for this change
Part of: #2443
What changes are included in this PR?
How are these changes tested?
A new UT has been added.