chore: Add UnboundColumn to carry datatype for unbound reference #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is proposed to fix the issue in #403 when upgrading to latest DataFusion. |
huaxingao
approved these changes
Jun 5, 2024
huaxingao
reviewed
Jun 5, 2024
| Ok(self.datatype.clone()) | ||
| } | ||
|
|
||
| /// Decide whehter this expression is nullable, given the schema of the input |
There was a problem hiding this comment.
I copied it from DataFusion. 😂
viirya
commented
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
============================================
+ Coverage 34.05% 34.07% +0.02%
+ Complexity 859 809 -50
============================================
Files 116 105 -11
Lines 38679 38509 -170
Branches 8567 8552 -15
============================================
- Hits 13173 13123 -50
+ Misses 22745 22643 -102
+ Partials 2761 2743 -18 ☔ View full report in Codecov by Sentry. |
advancedxy
approved these changes
Jun 5, 2024
DataFusion doesn't need it. |
|
Merged. Thanks @huaxingao @advancedxy |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…che#518) * chore: Add UnboundColumn to carry datatype for unbound reference * Update core/src/execution/datafusion/expressions/unbound.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #511.
Rationale for this change
What changes are included in this PR?
How are these changes tested?