-
Notifications
You must be signed in to change notification settings - Fork 668
Add basic support for GRANT and REVOKE #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b2f1874
Add basic support for GRANT privileges on tables and sequences
blx dbb6391
Cargo fmt
blx 0e28a94
Make enum for granted privileges
blx ff710b5
Implement and use Display for GrantObjects
blx 422d4f9
Simplify Display for GrantPrivileges
blx 9f07901
Add column privileges
blx 59fe5f2
Add second column privilege to test
blx fd6ff83
Add REVOKE privileges and reformat
blx c42839f
Merge remote-tracking branch 'sqlparser-rs/main' into grant
alamb 0931822
Merge remote-tracking branch 'sqlparser-rs/main' into grant
alamb 3c58d92
Fix some clippy warnings
alamb d427cee
Fix more clippy
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth removing it from the struct then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alamb I erred on the side of losslessness here, but I wasn't sure to what degree that's a goal.
I guess there are already many cases where an implied default becomes explicit when parsed, and would then produce different output after a roundtrip if the input had omitted the default (eg.
cascadeinStatement::Drop).If you think it would be cleaner I'm happy to PR removing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this field is needed to survive the round trip I think keeping it makes sense.