parse grouping sets, rollup, and cube for postgresql #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Pull Request Test Coverage Report for Build 1563508887
💛 - Coveralls |
jimexist
force-pushed
the
cube-rollup-grouping-sets
branch
from
2684527 to
6670d50
Compare
|
need to rebase onto #367 |
houqp
approved these changes
Nov 22, 2021
alamb
reviewed
Dec 8, 2021
src/parser.rs
Outdated
| /// parse a group by expr. a group by expr can be one of group sets, roll up, cube, or simple | ||
| /// expr. | ||
| fn parse_group_by_expr(&mut self) -> Result<Expr, ParserError> { | ||
| if self.parse_keywords(&[Keyword::GROUPING, Keyword::SETS]) { |
There was a problem hiding this comment.
I double checked at MySql also supports GROUPING, though it seems it supports WITH ROLLUP rather than ROLLUP, https://dev.mysql.com/doc/refman/8.0/en/group-by-modifiers.html
but seemingly not CUBE https://dev.mysql.com/doc/search/?d=201&p=1&q=cube
I think we should make parsing this part of the syntax conditional on the the postgresql dialect
jimexist
force-pushed
the
cube-rollup-grouping-sets
branch
from
6670d50 to
ddf96c7
Compare
jimexist
force-pushed
the
cube-rollup-grouping-sets
branch
from
ddf96c7 to
b415c8f
Compare
jimexist
changed the title
houqp
approved these changes
Dec 10, 2021
alamb
reviewed
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.