Skip to content

Provide valid extensionUris and extensionUriReferences in Substrait #11545

@Blizzara

Description

@Blizzara

Describe the bug

The Substrait produced by DF contains SimpleExtensionsDeclarations. See https://substrait.io/extensions/#simple-extensions for definition and https://substrait.io/tutorial/sql_to_substrait/#plans for an example (the example only has scalar functions but idea is the same for types and type variations). However, it does not contain proper SimpleExtensionUris, but rather uses a hardcoded extensionUriReference of max i32.

We should switch to providing proper SimpleExtensionUris with correct references.

To Reproduce

No response

Expected behavior

DF-produced Substrait plans contain valid extensionUris like shown here: https://substrait.io/tutorial/sql_to_substrait/#plans

Additional context

Technically, the SimpleExtensions should be defined in YAML files, like the ones here: https://github.com/substrait-io/substrait/blob/a68c1ac62f92d703da624cb8ac0cef854dd2b35f/extensions. That however makes some things more strict than they are now, and there are open questions in Substrait around how to evolve those files etc. So as the first alternative, we could consider just providing a reference to an imaginary uri rather than pointing to a proper YAML.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions