Skip to content

Align UDF names to lowercase or uppercase #11779

@edmondop

Description

@edmondop

Describe the bug

As a part of performing this change, @jayzhan211 recommended to use min and max as a default name for the new UDFs rather than the lowercase. However, performing this change makes test fails because in several places we use MAX and MIN, for example:

https://github.com/apache/datafusion/blob/0332eb569a5428ac385fe892ce7b5fb40d52c8c0/datafusion/sqllogictest/test_files/tpch/q15.slt.part use MAX uppercase that would cause build failure when comparing LogicalPlan like in the following build:
https://github.com/apache/datafusion/actions/runs/10215600305/job/28265554129?pr=11013

In the rust tests as well we use avg but MAX, so we need to update those tests as well

"| c1 | MIN(aggregate_test_100.c12) | MAX(aggregate_test_100.c12) | avg(aggregate_test_100.c12) | sum(aggregate_test_100.c12) | count(aggregate_test_100.c12) | count(DISTINCT aggregate_test_100.c12) |",

To Reproduce

No response

Expected behavior

No response

Additional context

I have not verified if MAX and MIN are the only UDF for which we use uppercase rather than lowercase. I personally prefer to have all SQL KEYWORDS (including UDF names) uppercase for readability

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions