Skip to content

Implement ordering serialization for AggregateUdf in datafusion-proto #11804

@alamb

Description

@alamb

Is your feature request related to a problem or challenge?

As @jayzhan211 points out on #11013 (comment) the ordering_req field is not supported when serializating/deserializing aggregate udfs

Describe the solution you'd like

Add ordering_req to the serialization / deserializton of aggregateudf and add a test

Describe alternatives you've considered

Here is the code where the ordeirng is ignored when serializing

let _ordering_req: Vec<PhysicalSortExpr> = agg_node.ordering_req.iter()
.map(|e| parse_physical_sort_expr(e, registry, &physical_schema, extension_codec)).collect::<Result<Vec<_>>>()?;

Additional context

I think technically this may be a regression as builtin functions had proper ordering serialization

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestregressionSomething that used to work no longer does

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions