-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Is your feature request related to a problem or challenge?
This is a follow on to #9743 where @gstvg added a great named_struct function to construct StructArrays ❤️
As part of that PR, @yyy1000 noted that the existing code in the struct udf is now never called: #9743 (comment)
Describe the solution you'd like
-
Make the invoke()` function reutrn a not yet implemented error https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/functions/src/core/struct.rs#L90-L92
-
Implement the
simplifyAPI to rewrite calls tostruct()to a call tonamed_struct
- Update the sql planner to call
structrather than building up thec0, `c1, etc and calling named_struct
Describe alternatives you've considered
We could also just remove the struct udf entirely, though in that case it is important to keep the struct expr_fn function for backwards compatibility
I think it could be implemented as its own function like
Additional context
No response
jayzhan211 and yyy1000
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers