fix: Specify row count in sort_batch for batch with no columns #10094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Apr 16, 2024
| fn sort_in_mem_batches(self: &mut Pin<&mut Self>) -> Result<RecordBatch> { | ||
| let input_batch = concat_batches(&self.schema(), &self.in_mem_batches)?; | ||
| self.in_mem_batches.clear(); | ||
| println!("input_batch: {:?}", input_batch); |
There was a problem hiding this comment.
Looks like some debug logging that needs to be removed?
alamb
changed the title
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Apr 16, 2024
Yea, that's good idea. The physical query plan goes through Spark optimizer. It seems there is no corresponding optimization rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10093.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?