Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented May 9, 2024

Which issue does this PR close?

Related to #10291

Rationale for this change

While reviewing this code for #10291 I found several places the doc comments could be improved, and I thought those changes would be easy to review as their own PR

What changes are included in this PR?

  • make // to ///
  • Add some additional markdown style

Are these changes tested?

Are there any user-facing changes?

No this is internal documentation -- none of these changes are user facing

@alamb alamb changed the title Minor: format comments in filter pushdown rule Minor: format comments in PushDownFilter rule May 9, 2024
@alamb alamb marked this pull request as ready for review May 9, 2024 17:40
@alamb alamb added the documentation Improvements or additions to documentation label May 10, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb alamb merged commit 490fdf9 into apache:main May 10, 2024
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants