Fix broken build/test from merge #10637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @alamb - I think we should merge this in relatively quickly so that builds/tests aren't broken |
alamb
approved these changes
May 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @phillipleblanc 🙏
| Ok(()) | ||
| } | ||
|
|
||
| #[test] |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Move and fix test test_table_references_in_plan_to_sql * merge issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes a merge issue that resulted in a broken build/test.
Rationale for this change
We should have working builds and tests!
What changes are included in this PR?
Moves the test
test_table_references_in_plan_to_sqlto where the rest of theplan_to_sqltests are for now. Also fixes a merge issue between 7757d63 and 7bd4b53Are these changes tested?
Yes
Are there any user-facing changes?
No