Rewrite array @> array and array <@ array in sql_expr_to_logical_expr
#11155
Conversation
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
sql
Signed-off-by: jayzhan211 <[email protected]>
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @jayzhan211 -- this looks good to me
Can you remind me why this method is preferrable to the FunctionRewrite idea we previously had?
I feel this PR and changes are related to the one from @samuelcolvin on #11137 -- where the idea is to support SQL syntax with JSON operators without putting the implementation into SQL
| } | ||
|
|
||
| #[test] | ||
| fn select_at_arrow_operator() { |
There was a problem hiding this comment.
Should we add an explain test?
There was a problem hiding this comment.
I don't think it is needed since we don't really care about how it looks in plan.
There was a problem hiding this comment.
Maybe we can make sure array_has_all is applied 🤔
|
Here is an alternate idea #11168 |
From your comment here :) #10534 (comment) |
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
forgot to remove in previous PR
…expr (apache#11155) * rewrite at arrow Signed-off-by: jayzhan211 <[email protected]> * rm useless test Signed-off-by: jayzhan211 <[email protected]> * add test Signed-off-by: jayzhan211 <[email protected]> * rm test Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
2 participants
Which issue does this PR close?
Part of #8506 #10534
Rationale for this change
Move the rewrite from optimizer to sql crate
I keep the function rewrite trait even it is not used anywhere in datafusion now.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?