Fix: Remove Unrelated Fields When Expanding Wildcards in Functional Dependency Projections #12060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
approved these changes
Aug 19, 2024
Co-authored-by: Mehmet Ozan Kabak <[email protected]>
github-actions
bot
added
logical-expr
goldmedal
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Thank @berkaysynnada for fixing this. LGTM. Just one minor comment.
I'm sorry for missing this case 😭
| ); | ||
|
|
||
| statement ok | ||
| CREATE TABLE exchange_rates ( |
There was a problem hiding this comment.
How about dorp sales_global and exchange_rates after the test?
|
Thank you @goldmedal for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12054.
Rationale for this change
Our downstream tests started failing after #11681. In
calc_func_dependencies_for_project(), the projection length is no longer taken from the expression length. Instead, wildcard expressions are now counted based on the number of fields in the wildcard schema. The problem occurs when the wildcard expression has a table reference, but the wildcard schema is built on multiple tables.What changes are included in this PR?
This PR filters the wildcard schema according to the table reference of the wildcard expression.
Are these changes tested?
Yes, a minimal example of our failing test has been added to
joins.slt.Are there any user-facing changes?