Skip to content

Conversation

@edmondop
Copy link
Contributor

Which issue does this PR close?

I had created #11595 which I had created when working on #11013

When I was using create_aggregate_expr, aliases for max_udaf wouldn't be serialized, as indicated in #11595 . However, using the AggregateExprBuilder solved the problem, so the issue was probably in create_aggregate_expr , which by the way has been removed from the codebase, so we need to update the contributors how-to
https://github.com/apache/datafusion/blob/main/docs/source/contributor-guide/howtos.md?plain=1#L62

@github-actions github-actions bot added the proto Related to proto crate label Aug 28, 2024
@crepererum
Copy link
Contributor

which by the way has been removed from the codebase, so we need to update the contributors how-to
https://github.com/apache/datafusion/blob/main/docs/source/contributor-guide/howtos.md?plain=1#L62

Do you mind fixing this or extracting this comment into a new issue? Just so it doesn't get lost.

@edmondop
Copy link
Contributor Author

Apologies, I did it yesterday but forgot to link the issue here #12220

@crepererum crepererum merged commit 650dfdc into apache:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants