Minor: Encapsulate type check in GroupValuesColumn, avoid panic #12620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
approved these changes
Sep 25, 2024
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs
Outdated
Show resolved
Hide resolved
comphead
reviewed
Sep 25, 2024
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs
Outdated
Show resolved
Hide resolved
comphead
reviewed
Sep 25, 2024
| fn supported_type(data_type: &DataType) -> bool { | ||
| matches!( | ||
| *data_type, | ||
| DataType::Int8 |
There was a problem hiding this comment.
should we use DataType::is_signed_integer DataType::is_unsigned_integer
we can also use is_numeric but it includes Decimals
There was a problem hiding this comment.
This list needs to be kept in sync with what special implementations are available in GroupValuesColumns -- I will add a comment to make that clearer
comphead
approved these changes
Sep 25, 2024
…se.rs Co-authored-by: Oleks V <[email protected]>
…o alamb/minor_cleanup
|
Thank you for the review @jayzhan211 |
|
Thanks @comphead and @jayzhan211 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #12269 from @jayzhan211
Rationale for this change
I had some minor suggestions during review: #12269 (review)
What changes are included in this PR?
Are these changes tested?
CI
Are there any user-facing changes?