Skip to content

Conversation

@jonathanc-n
Copy link
Contributor

Which issue does this PR close?

Closes #12868 .

Rationale for this change

Migrated regex functions.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added documentation Improvements or additions to documentation functions Changes to functions implementation labels Oct 12, 2024
@Omega359
Copy link
Contributor

Beyond fixing the copy/paste error for the get_regexp_replace_doc fn name lgtm.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanc-n and @Omega359

I pushed a commit to regenerate the documentation to get the CI to pass

thank you for keeping the train moving

@alamb alamb merged commit fce331a into apache:main Oct 14, 2024
25 checks passed
hailelagi pushed a commit to hailelagi/datafusion that referenced this pull request Oct 14, 2024
* regex migrate

* small fixes

* update docs

---------

Co-authored-by: Andrew Lamb <[email protected]>
@jonathanc-n jonathanc-n deleted the regex-doc-migration branch November 17, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate documentation for all regex functions from scalar_functions.md to code

3 participants