Prevent take_optimizable from discarding arbitrary plan node #13030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`take_optimizable` started from inspecting top level plan node (it should be final aggregation) and then descended trying to find matching partial aggregation. When doing so, it would ignore any single-source nodes it passes by. As a result, `AggregateStatistics` could change the plan in an undesired manner.
findepi
force-pushed
the
findepi/prevent-take-optimizable-from-discarding-arbitrary-plan-node-11408b
branch
from
d54d101 to
7f67ab7
Compare
|
this is not correct in strict sense -- if we defined Logical Plan semantics by defining each plan node separately as a function of its inputs, but maybe no-one gets hurt in the near term, given that in typical logical plans the final and partial won't be very far apart. closing for now, to be fixed later. |
findepi
deleted the
findepi/prevent-take-optimizable-from-discarding-arbitrary-plan-node-11408b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take_optimizablestarted from inspecting top level plan node (it should be final aggregation) and then descended trying to find matching partial aggregation. When doing so, it would ignore any single-source nodes it passes by. As a result,AggregateStatisticscould change the plan in an undesired manner.Extracted from #13029