extended log.rs tests for unary/binary and f32/f64 casting #13034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
approved these changes
Oct 21, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like an improvement to me -- thank you @buraksenn
Contributor
|
It seems that these tests don't cover the intended case yet. Can you find a unit or slt test failing with the change 58d3d86 |
Contributor
Author
Yes @berkaysynnada , scalar tests were missing. I've also added them |
Contributor
|
LGTM, thank you @buraksenn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13020.
Rationale for this change
Unit tests in log.rs do not cover unary case and failure case. Also added explicit casting to slt tests for f32 and f64 with log(x) and log(x,y) to cover all cases
What changes are included in this PR?
-added tests
Are these changes tested?
changes are only tests and all tests pass
Are there any user-facing changes?
no