Skip to content

Conversation

@LatrecheYasser
Copy link
Contributor

@LatrecheYasser LatrecheYasser commented Oct 25, 2024

Which issue does this PR close?

Similar to #13108.

This PR adds support for negate arithmetic expression, which is the official substrait expression for negative.
The test case was already implemented here.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the substrait Changes to the substrait crate label Oct 25, 2024
@LatrecheYasser LatrecheYasser changed the title Support negate expression in substrait Support negate arithmetic expression in substrait Oct 26, 2024
@LatrecheYasser LatrecheYasser marked this pull request as ready for review October 26, 2024 20:27
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LatrecheYasser

@alamb alamb merged commit c03e260 into apache:main Oct 29, 2024
28 checks passed
@alamb alamb mentioned this pull request Nov 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants