Skip to content

Conversation

@Michael-J-Ward
Copy link
Contributor

Which issue does this PR close?

Closes #13148.

Rationale for this change

ExpressionArgs is needed to implement WindowUDFImpl as of #12857, but it is not currently re-exported.

What changes are included in this PR?

ExpressionArgs is re-exported in datafusion_expr::function.

I placed it here because that is where WindowUDFFieldArgs and PartitionEvaluatorArgs are re-exported.

Are these changes tested?

N/A

Are there any user-facing changes?

Not from any released version

This struct is needed to implement the WindowUDFImpl trait.
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Oct 29, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@alamb alamb merged commit b30d12a into apache:main Oct 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

re-export ExpressionArgs

2 participants