Skip to content

Conversation

@rdettai
Copy link
Contributor

@rdettai rdettai commented Nov 19, 2021

Rationale for this change

Avoids that aggr_test_schema() is declared twice

What changes are included in this PR?

  • Move aggr_test_schema() to test_util.rs
  • Remove aggr_test_schema() from test/mod.rs
  • Remove common.rs in tests

Are there any user-facing changes?

No

This avoids that its duplicated in the benchmark package.
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks @rdettai

@@ -1,40 +0,0 @@
// Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 0facd4d into apache:master Nov 19, 2021
xudong963 pushed a commit to xudong963/arrow-datafusion that referenced this pull request Nov 28, 2021
This avoids that its duplicated in the benchmark package.
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants