Deprecate adjust_output_array in favor of PrimitiveArray::with_data_type
#13585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/deprecate_adjust_datatype
branch
from
4ec0a12 to
8bb087c
Compare
jayzhan211
approved these changes
Nov 28, 2024
Contributor
|
Thanks @alamb |
alamb
commented
Nov 28, 2024
| let vals = Arc::new(PrimitiveArray::<VAL>::from_iter_values(vals)); | ||
| let vals = adjust_output_array(&self.data_type, vals).expect("Type is incorrect"); | ||
| (vals, map_idxs) | ||
| let arr = PrimitiveArray::<VAL>::new(ScalarBuffer::from(vals), nulls) |
Contributor
Author
There was a problem hiding this comment.
I believe this will also be slightly faster as the ScalarBuffer::from avoids copying the values into the Vec: https://docs.rs/arrow/latest/arrow/buffer/struct.ScalarBuffer.html#impl-From%3CVec%3CT%3E%3E-for-ScalarBuffer%3CT%3E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Decimal128Array#13564Rationale for this change
While reviewing #13564 (review) @jayzhan211 pointed out this function wasn't necessary as there is now equivalent functionality in arrow-rs
It is confusing there are two patterns to do the same thing, so let's remove the DataFusion specific pattern
What changes are included in this PR?
PrimitiveArray::with_data_typeinsteadAre these changes tested?
By CI
Are there any user-facing changes?